Re: [PATCH 12/13] ARM: OMAP5: Add the build support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony,

On 5/7/2012 7:37 PM, Tony Lindgren wrote:
* R, Sricharan<r.sricharan@xxxxxx>  [120506 20:39]:
+config MACH_OMAP5_SEVM
+     bool "OMAP5 sevm Board"
+     depends on ARCH_OMAP5
+
  config OMAP3_EMU
       bool "OMAP3 debugging peripherals"
       depends on ARCH_OMAP3

No need for it here either. Actually, I think this whole chunk
can be now left out since it's DT based?
he
  ok, but the concern here was that without this macro
  the print from compress and subsequently early
prints appear broken.

machine_is_omap5_sevm becomes zero without this config and
machine_is_xxxx is used by the macro _DEBUG_LL_ENTRY
uncompress.h.

Ah I see.

Mmm, still, I guess this mechanism should be deprecated with DT?
We cannot keep creating fake board entry since we are not supposed to have MACHINE_ID anymore. That will break DEBUG_LL for sure, but we knew about that current limitation with DT.

The point is that we should fix the code to stop relying on a machine id going forward.
And maybe we can parse the FDT at that time?

Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux