Re: [PATCH 02/13] ARM: OMAP5: Add minimal support for OMAP5430 SOC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Paul Walmsley <paul@xxxxxxxxx> [120507 12:11]:
> Hi,
> 
> On Fri, 4 May 2012, Tony Lindgren wrote:
> 
> > How about we add CONFIG_SOC_OMAP3PLUS in the clean-up series?
> > Then this becomes just:
> > 
> > #ifdef CONFIG_SOC_OMAP3PLUS
> 
> We might want to consider having separate CONFIG_SOC_* values for each 
> SoC.  So rather than CONFIG_SOC_OMAP3PLUS, we'd have CONFIG_SOC_OMAP3430, 
> CONFIG_SOC_OMAP3630, etc.

Hmm but this would be in addition to the SOC specific options. The goal
is to cut down the ifdeffery needed all over the place to add new SoCs,
see the experimental patch I posted:

http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg67938.html

> This would be for two main reasons.  One is that Kconfig options like 
> CONFIG_SOC_OMAP3PLUS don't have much meaning.  It is really unclear to me 
> what SoCs would be included in CONFIG_SOC_OMAP3PLUS, since some of them 
> differ so radically -- different interconnects, different power and system 
> management IP blocks, different CPU subsystems, different RAM controllers, 
> etc.  The advantage of using SoC-specific Kconfig options, from this point 
> of view, is that it is easy to know what they mean.  Then those 
> SoC-specific Kconfig options can select the appropriate SoC-independent 
> interconnect driver, PRCM drivers, CPU options, etc.

Just to continue exploring just using the SoC specific options, we would
currently end up with more of this kind of nastiness:

#if defined(CONFIG_ARCH_OMAP4) && !(defined(CONFIG_ARCH_OMAP2) ||      \
					defined(CONFIG_ARCH_OMAP3))
 
> The other motivation would be to support device manufacturers who only 
> wish to build a kernel for the single device that they are shipping.  In 
> terms of kernels shipped, this is probably the most popular use-case. With 
> something like CONFIG_SOC_OMAPAM33XX, they can avoid building quite a bit 
> of code and data (and potentially bugs) that are not needed for their 
> specific device.

Sure, but I think you're missing the point: This would be in addition
to the SoC specific options. Do you still see issues with that?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux