Hi Benoit, Thanks for the reviews. > >> Adding the minimal support for OMAP5 soc with device tree. > > > You should probably split that patch since you are doing several things that > are not OMAP5 related. > > Do a patch that move the omap_init_irq into the INTC and GIC code first. > > Then, you can add a patch to add the OMAP5_DT machine entry. > ok, will split this then accordingly. [snip] >> @@ -185,6 +185,8 @@ void omap3_intc_prepare_idle(void); >> void omap3_intc_resume_idle(void); >> void omap2_intc_handle_irq(struct pt_regs *regs); >> void omap3_intc_handle_irq(struct pt_regs *regs); >> +void omap_of_init_irq(void); > > > In order to be consistent with the GIC function and even the previous ones, > you should name the exported one: > > +void omap_intc_of_init(void); > Ok, will take care of this rename. >> >> @@ -279,6 +280,16 @@ int __init omap_intc_of_init(struct device_node >> *node, > > > And thus rename that one that become a private function without the omap_ > prefix. > ok.. Thanks, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
