On Mon, 2012-05-07 at 17:30 +0530, Vishwanath Sripathy wrote: > Hi Tero, > > > -----Original Message----- > > From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap- > > owner@xxxxxxxxxxxxxxx] On Behalf Of Tero Kristo > > Sent: Friday, May 04, 2012 7:27 PM > > To: linux-omap@xxxxxxxxxxxxxxx; khilman@xxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Nishanth Menon > > Subject: [PATCH 2/3] ARM: OMAP3+: PM: introduce a central pmic > > control > > > > From: Nishanth Menon <nm@xxxxxx> > > > > Since we are starting to use multiple PMICs in various combinations, > > use the existing .omap_chip = OMAP_CHIP_INIT() to mark the > > structures we are interested in using per OMAP device we > > are currently running on. This mapping is based on the default > > device recommendations from TI. Boards using custom PMICs now > > have an opportunity to register their own custom mapping. > > > > With this we no longer need omap4_twl_init and omap3_twl_int > > instead we introduce a registration mechanism which is PMIC > > generic and move twl implementation to use the same. This allows > > for future OMAP4460 support where there is a mixture of > > PMIC combinations used. > In this patch, you seem to be tying PMIC configuration with a OMAP version > which I think is not quite appropriate. Rather it should be a board > dependent parameter. We have many boards based on 4460 chip with different > PMICs. This implementation will not be able to support all such > configurations. The ICS tree contains tweaks for this purpose, allowing the mapping to be modified during init time by board files. This should only be the default setup, and once support for boards that do not use default setup is added, we should modify this. However, if someone can provide me specs how the multi PMIC support should actually work, I am willing to implement this. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
