One other minor thing I just noticed...
On Wed, 11 Apr 2012, Mark A. Greer wrote:
> +ENTRY(omap3_emif4_do_wfi)
> + /* Put EMIF in self-refresh */
> + ldr r4, pwr_mgmt_ctrl
> + ldr r5, [r4]
> + orr r5, r5, #0x200
> + str r5, [r4]
> +
> + dsb
> + dmb
> +
> + wfi
> +
> + nop
> + nop
> + nop
> + nop
> + nop
> + nop
> + nop
> + nop
> + nop
> + nop
> +
> + /* Take EMIF out of self-refresh */
> + ldr r4, pwr_mgmt_ctrl
> + ldr r5, [r4]
Looks like the above two instructions might not be needed -- they should
be preserved across the WFI ?
> + bic r5, r5, #0x200
> + str r5, [r4]
> +
> + ldmfd sp!, {r4 - r11, pc} @ restore regs and return
> +
> +pwr_mgmt_ctrl:
> + .word PWR_MGMT_CTRL_V
> +ENDPROC(omap3_emif4_do_wfi)
> +ENTRY(omap3_emif4_do_wfi_sz)
> + .word . - omap3_emif4_do_wfi
> +
- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
