* Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> [120321 12:03]: > On Wed, Mar 21, 2012 at 11:39:57AM -0700, Tony Lindgren wrote: > > * Porter, Matt <mporter@xxxxxx> [120321 11:27]: > > > > > Hrm? Adding regulator supply mappings anywhere other than the > > > > initialisation for a specific board would be extremely unusual and > > > > rather suspicious. > > > The issue here is that we don't want to copy paste the dummy fixed > > regulator all over the board-*.c files, and we don't know how the > > real regulator is wired up. > > Well, I don't think it's too unreasonable especially now we've got > the fixed helper stuff which slims it right down - it makes it clear > there's a missing thing that might need to get filled in and makes it > easier to use the same regulator for other devices. Right I guess that's a one liner macro now. > > > Just to be clear, here is the thread on the board-specific approach: > > > https://lkml.org/lkml/2012/2/8/415 > > > We should use the real regulator if passed from board file. > > > And if no real regulator is passed, just use the dummy fixed regulator > > in gpmc-smsc911x.c. > > Yes, it should definitely be conditional. > > > This patch I posted should fix the situation and allow adding the > > real regulators to board-*.c files when they become known: > > > http://www.spinics.net/lists/linux-omap/msg66714.html > > That should be changed to pass in a boolean flag rather than a pointer > to platform device - the board may not have direct access to the > relevant regulator (eg, if it's part of a MFD) or the regulator may be > on another bus like I2C (for simpler regulator only devices). Hmm I see. This means that we need to patch some board files anyways for the boolean flag to use the fixed regulator. This is because for some cases vddvario and vdd33a regulators can come from the mfd/tps/twl chip and it's unsafe to assume that gpmc-smsc911x.c can set up these regulators automatically. Passing a boolean flag to not set up the default regulator would work too, but we'd rather eventually see the real board specific regulators being patched in. So if that's the case, we might as well patch the board files to add the fixed regulators for each one and drop all the regulator code from gpmc-smsc911x.c. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
