* Porter, Matt <mporter@xxxxxx> [120321 11:27]: > > On Mar 21, 2012, at 2:13 PM, Mark Brown wrote: > > > On Wed, Mar 21, 2012 at 10:55:54AM -0700, Russ Dill wrote: > > > >> unwieldy this would become if it were done for every device. Either the > >> functionality needs to be moved to Snowball board init code, or a generic > >> framework needs to be made for attaching regulators to arbitrary devices. > > > > Hrm? Adding regulator supply mappings anywhere other than the > > initialisation for a specific board would be extremely unusual and > > rather suspicious. The issue here is that we don't want to copy paste the dummy fixed regulator all over the board-*.c files, and we don't know how the real regulator is wired up. > Just to be clear, here is the thread on the board-specific approach: > https://lkml.org/lkml/2012/2/8/415 We should use the real regulator if passed from board file. And if no real regulator is passed, just use the dummy fixed regulator in gpmc-smsc911x.c. This patch I posted should fix the situation and allow adding the real regulators to board-*.c files when they become known: http://www.spinics.net/lists/linux-omap/msg66714.html Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
