Hi Keshava, On Thu, Mar 08, 2012 at 08:30:21PM +0530, Munegowda, Keshava wrote: > On Fri, Mar 2, 2012 at 7:36 PM, Munegowda, Keshava > <keshava_mgowda@xxxxxx> wrote: > > On Fri, Feb 24, 2012 at 5:14 PM, Munegowda, Keshava > > <keshava_mgowda@xxxxxx> wrote: > >> On Fri, Feb 24, 2012 at 3:46 PM, Felipe Balbi <balbi@xxxxxx> wrote: > >>> Hi, > >>> > >>> On Fri, Feb 24, 2012 at 03:36:15PM +0530, Keshava Munegowda wrote: > >>>> From: Keshava Munegowda <Keshava_mgowda@xxxxxx> > >>>> > >>>> It is observed that the echi ports of 3430 sdp board > >>>> are not working due to the random timing of programming > >>>> the associated GPIOs of the ULPI PHYs of the EHCI for reset. > >>>> If the PHYs are reset at during usbhs core driver, host ports will > >>>> not work because EHCI driver is loaded after the resetting PHYs. > >>>> The PHYs should be in reset state while initializing the EHCI > >>>> controller. > >>>> The code which does the GPIO pins associated with the PHYs > >>>> are programmed to reset is moved from the USB host core driver > >>>> to EHCI driver. > >>>> > >>>> Signed-off-by: Keshava Munegowda <keshava_mgowda@xxxxxx> > >>>> Reviewed-by: Partha Basak <parthab@xxxxxxxxxxxx> > >>> > >>> won't this cause issues with EHCI/OHCI interactions ? I mean, what if > >>> you connect a FS/LS device and port is handed over to OHCI, does OHCI > >>> have any needs to reset the PHY or something similar ? > >> > >> No, it will not cause any issues with EHCI-OHCI issues. > >> But its difficult to comment on this because we don't have port > >> handoff supported > >> in hardware. > >> > >> regards > >> keshava > > > > Hi Samuel > > please let me know if you have any comments on this patch. > > This is required patch for omap3 ehci enumeration instabilities. > > > > Regards > > Keshava > > Hi Samuel > do you have any comments on this patch? I actually never received the actual patch, I think. > Felipe has reviewed this patch and he is agreed for this patch. > there are no comments from your side, requesting to push this change > to mainline. I looked at it on gmame, and it seems fine to me. If you want me to push this patch, then please (re-)send it to me, even privately. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
