Am 09.03.2012 19:31, schrieb Tony Lindgren:
> Hi Luca,
>
> * Mircea Gherzan <mgherzan@xxxxxxxxx> [120306 14:23]:
>> The "uim" deamon requires sysfs entries that are filled in using
>> this platform data.
>>
>> Signed-off-by: Mircea Gherzan <mgherzan@xxxxxxxxx>
>> ---
>> arch/arm/mach-omap2/board-omap4panda.c | 14 ++++++++++++--
>> include/linux/ti_wilink_st.h | 2 ++
>> 2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
>> index b1d74d6..339e781 100644
>> --- a/arch/arm/mach-omap2/board-omap4panda.c
>> +++ b/arch/arm/mach-omap2/board-omap4panda.c
>> @@ -27,6 +27,7 @@
>> #include <linux/i2c/twl.h>
>> #include <linux/regulator/machine.h>
>> #include <linux/regulator/fixed.h>
>> +#include <linux/ti_wilink_st.h>
>> #include <linux/wl12xx.h>
>>
>> #include <mach/hardware.h>
>> @@ -56,12 +57,21 @@
>> #define HDMI_GPIO_HPD 63 /* Hotplug detect */
>>
>> /* wl127x BT, FM, GPS connectivity chip */
>> -static int wl1271_gpios[] = {46, -1, -1};
>> +static struct ti_st_plat_data wilink_platform_data = {
>> + .nshutdown_gpio = 46,
>> + .dev_name = "/dev/ttyO1",
>> + .flow_cntrl = 1,
>> + .baud_rate = 3000000,
>> + .chip_enable = NULL,
>> + .suspend = NULL,
>> + .resume = NULL,
>> +};
>> +
>> static struct platform_device wl1271_device = {
>> .name = "kim",
>> .id = -1,
>> .dev = {
>> - .platform_data = &wl1271_gpios,
>> + .platform_data = &wilink_platform_data,
>> },
>> };
>>
>> diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h
>> index 2ef4385..3ca0269 100644
>> --- a/include/linux/ti_wilink_st.h
>> +++ b/include/linux/ti_wilink_st.h
>> @@ -25,6 +25,8 @@
>> #ifndef TI_WILINK_ST_H
>> #define TI_WILINK_ST_H
>>
>> +#include <linux/skbuff.h>
>> +
>> /**
>> * enum proto-type - The protocol on WiLink chips which share a
>> * common physical interface like UART.
>> --
>
> Just checking.. Can you please take a look at this patch
> and confirm that this is how things are supposed to be done?
>
> To me passing some third driver's dev_name in pdata seems
> pretty weird.. But then again maybe I just don't know how
> this is supposed to work.
This is what the ti_st driver expects in the platform data structure.
More precisely, in kim_probe():
/* copying platform data */
strncpy(kim_gdata->dev_name, pdata->dev_name,UART_DEV_NAME_LEN);
kim_gdata->flow_cntrl = pdata->flow_cntrl;
kim_gdata->baud_rate = pdata->baud_rate;
pr_info("sysfs entries created\n");
So IMHO the patch is a valid fix. However, one more patch [1] is still
required to get BT and WLAN working on the PandaBoard.
Thanks,
Mircea
[1] http://elinux.org/images/8/8d/0001a-omap4-pandaboard-wlan-fix.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
