On Fri, 2012-03-09 at 10:31 -0800, Tony Lindgren wrote:
> Hi Luca,
Hi Tony,
> * Mircea Gherzan <mgherzan@xxxxxxxxx> [120306 14:23]:
> > The "uim" deamon requires sysfs entries that are filled in using
> > this platform data.
> >
> > Signed-off-by: Mircea Gherzan <mgherzan@xxxxxxxxx>
> > ---
> > arch/arm/mach-omap2/board-omap4panda.c | 14 ++++++++++++--
> > include/linux/ti_wilink_st.h | 2 ++
> > 2 files changed, 14 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-omap4panda.c b/arch/arm/mach-omap2/board-omap4panda.c
> > index b1d74d6..339e781 100644
> > --- a/arch/arm/mach-omap2/board-omap4panda.c
> > +++ b/arch/arm/mach-omap2/board-omap4panda.c
> > @@ -27,6 +27,7 @@
> > #include <linux/i2c/twl.h>
> > #include <linux/regulator/machine.h>
> > #include <linux/regulator/fixed.h>
> > +#include <linux/ti_wilink_st.h>
> > #include <linux/wl12xx.h>
> >
> > #include <mach/hardware.h>
> > @@ -56,12 +57,21 @@
> > #define HDMI_GPIO_HPD 63 /* Hotplug detect */
> >
> > /* wl127x BT, FM, GPS connectivity chip */
> > -static int wl1271_gpios[] = {46, -1, -1};
> > +static struct ti_st_plat_data wilink_platform_data = {
> > + .nshutdown_gpio = 46,
> > + .dev_name = "/dev/ttyO1",
> > + .flow_cntrl = 1,
> > + .baud_rate = 3000000,
> > + .chip_enable = NULL,
> > + .suspend = NULL,
> > + .resume = NULL,
> > +};
> > +
> > static struct platform_device wl1271_device = {
> > .name = "kim",
> > .id = -1,
> > .dev = {
> > - .platform_data = &wl1271_gpios,
> > + .platform_data = &wilink_platform_data,
> > },
> > };
> >
> > diff --git a/include/linux/ti_wilink_st.h b/include/linux/ti_wilink_st.h
> > index 2ef4385..3ca0269 100644
> > --- a/include/linux/ti_wilink_st.h
> > +++ b/include/linux/ti_wilink_st.h
> > @@ -25,6 +25,8 @@
> > #ifndef TI_WILINK_ST_H
> > #define TI_WILINK_ST_H
> >
> > +#include <linux/skbuff.h>
> > +
> > /**
> > * enum proto-type - The protocol on WiLink chips which share a
> > * common physical interface like UART.
> > --
>
> Just checking.. Can you please take a look at this patch
> and confirm that this is how things are supposed to be done?
>
> To me passing some third driver's dev_name in pdata seems
> pretty weird.. But then again maybe I just don't know how
> this is supposed to work.
This looks pretty weird to me too. The "/dev/ttyO1" thing doesn't look
right. But I don't really know how this works either, because this is
the BT/FM/GPS part of the wl12xx chip. And, to be honest, I don't know
anything about it. I only know about the wifi part of it. :\
--
Cheers,
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
