On Fri, Mar 09, 2012 at 12:50:24PM -0700, Sagar Dharia wrote: > On 03/08/2012 05:21 PM, Marc Butler wrote: > > Thanks for providing this patch. My understanding is that this patch > provides helper functions for h/w controllers which rely on s/w to > provide the exact message to be sent out on the bus. Yes. The ti omap4430 expects the messages, to be complete except for the PI, MR, and MI fields which are encoded by the h/w. > Just like CRC, some other fields may be populated by HW. e.g. > Qualcomm chip also populates Arbitration priority, Arbitration > Extension fields. So it expects SW to only program a few fields, > a.k.a logical/elemental address, MT,MC, DT etc.(that too, SW > programs this based on software interface manual). The hardware will > convert this information to actual slimbus-compliant message and > send it on the bus. Understood. The functions are not incompatible with construction partial messages, but as it will not likely work when inserting the header field, as it goes about trying to compute the remaining length, based on the current (icomplete) message including the arbitration header. > Being said that, I am not aware of how majority of h/w controllers > work and will be open to have this patch if other hardwares rely on > s/w to provide the exact message as well. The ti omap4430 requires this support. Regards, -m -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html