Hi Tomi,
A while ago you were asking about why DSS pwrdm counts were so high on
OMAP3, and why DSS was transitioning even though it was completely
unused. Paul and I just spent some a little time debugging this, and
narrowed it down to autodeps. (sorry it took so long, it finally
bothered me enough to actually look into it.)
The patch below fixes the problem at least when DSS is not loaded (DSS
just stays in retention), but I didn't try this with any active DSS
usage, or loading/unloding the DSS drivers.
Could you give the patch below a try on OMAP3 along with some active DSS
usage as well as unloading the modules after using. Could you also
verify that suspend/resume continues to work for DSS?
Thanks,
Kevin
>From 42fc4f2acd9d6ba08992f8daa36297be384e76ef Mon Sep 17 00:00:00 2001
From: Kevin Hilman <khilman@xxxxxx>
Date: Thu, 8 Mar 2012 16:22:19 -0800
Subject: [PATCH] ARM: OMAP3: clockdomain: disable autodeps for DSS
Due to autodeps, the DSS powerdomain is transitioning with the MPU
powerdomain even when DSS is inactive.
autodeps are deprecated in favor of hwmod managing initiator
dependencies directly, and we're hoping to eventually remove them.
For starters, disable autodeps for DSS and see what happens...
Cc: Paul Walmsley <paul@xxxxxxxxx>
Signed-off-by: Kevin Hilman <khilman@xxxxxx>
---
arch/arm/mach-omap2/clockdomains3xxx_data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c
index b84e138..ba0285f 100644
--- a/arch/arm/mach-omap2/clockdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c
@@ -254,7 +254,7 @@ static struct clockdomain core_l4_3xxx_clkdm = {
static struct clockdomain dss_3xxx_clkdm = {
.name = "dss_clkdm",
.pwrdm = { .name = "dss_pwrdm" },
- .flags = CLKDM_CAN_HWSUP_SWSUP,
+ .flags = CLKDM_CAN_HWSUP_SWSUP | CLKDM_NO_AUTODEPS,
.dep_bit = OMAP3430_PM_WKDEP_MPU_EN_DSS_SHIFT,
.wkdep_srcs = dss_wkdeps,
.sleepdep_srcs = dss_sleepdeps,
--
1.7.9.2
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
