On Fri, Mar 02, 2012 at 11:19:40, Paul Walmsley wrote: > Hi > > On Thu, 1 Mar 2012, Hiremath, Vaibhav wrote: > > > I am not sure whether we access these bits explicitly. If I understand > > correctly, API's which access these bits are not being called from > > anywhere, For example, > > > > omap4_pwrdm_read_mem_retst > > omap4_pwrdm_set_mem_retst > > omap4_pwrdm_set_mem_onst > > They'll be needed for the functional powerstate code, device PM QoS, and > OSWR. > > > Currently the major issue would be, for PM_PER_PWRSTCTRL, where > > LogicRETState bit has been moved to offset 3. This is being used in > > omap4_pwrdm_set_logic_retst() api. > > > > And in order to support weird/non-standard bit-offsets, we have to clean > > omap2_pwrdm_get_mem_bank_onstate/retst/_mask() api and have bitshift > > field in struct powerdomain, as you have rightly pointed out. > > As you work on this, I have a request. Please place the AM33xx > powerdomain implementation functions into a separate file, > powerdomain33xx.c perhaps, rather than trying to merge them with the OMAP4 > powerdomain implementation functions. > That was my initial code and I had submitted same to the list as an RFC, Request you to refer to the link - http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg58746.html And the reason behind merging am33xx with omap4 thing was triggered from the discussion on the above patch (between me, KevinH and RajendraNaik), and we all believed that, with some cleanup in OMAP4 code we can reuse it for am33xx. Thanks, Vaibhav > Some functions can be shared -- maybe place those into a separate file, > powerdomain33xx_44xx.c perhaps? > > > Is my all understanding correct? > > > > If yes, do you think this patch should get blocked for above cleanup? I feel > > Cleanup can still follow, since this won't impact the AM33xx boot. > > > > What's your opinion on this?? > > We can't merge patches which are known to be broken. That's a rule from > Linus (and a good one). Better to try to get it right the first time it > hits mainline. > > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
