On 02/28/2012 07:47 PM, Tony Lindgren wrote:
> * Rob Herring <robherring2@xxxxxxxxx> [120226 19:15]:
>> On 02/24/2012 12:22 PM, Tony Lindgren wrote:
>>> * Tony Lindgren <tony@xxxxxxxxxxx> [120223 15:36]:
>>>> * Rob Herring <robherring2@xxxxxxxxx> [120221 17:53]:
>>>>> On 02/21/2012 05:40 PM, Tony Lindgren wrote:
>>>>>> +
>>>>>> +/*
>>>>>> + * NOTE: Please use ioremap + __raw_read/write where possible instead of these
>>>>>> + */
>>>>>> +
>>>>>> +extern u8 omap_readb(u32 pa);
>>>>>> +extern u16 omap_readw(u32 pa);
>>>>>> +extern u32 omap_readl(u32 pa);
>>>>>> +extern void omap_writeb(u8 v, u32 pa);
>>>>>> +extern void omap_writew(u16 v, u32 pa);
>>>>>> +extern void omap_writel(u32 v, u32 pa);
>>>>>
>>>>> These can't be moved to common.h like omap2?
>>>>
>>>> Not for omap1 currently because a bunch of legacy drivers are
>>>> using them :(
>>>
>>> Looks like we can have them in mach-omap1/include/mach/hardware.h.
>>>
>>> Eventually the SoC specific hardware.h files could be renamed to
>>> just something like omap1.h, omap2plus.h and so. And then they
>>> could be included in the common hardware.h.
>>>
>>> Updated patch below, now io.h for both omap1 and omap2+ are
>>> minimized, and turns out only minimal driver changes were needed.
>>>
>>
>> Looks good to me. Do you have a branch for this that I can base on?
>
> Yes it's now in iomap branch that merged into my cleanup branch that
> I'll ask Arnd and Olof to pull tomorrow.
>
> So take your pick out of the following two:
>
> 1. iomap branch based on v3.3-rc4 that you probably want to use
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap iomap
>
>
> 2. cleanup branch based on RMK's commit 61b80086a525c8a6081257ae40da5dee2bcaee16
> (Merge branch 'entry-macro-cleanup' of git://sources.calxeda.com/kernel/linux into for-armsoc)
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap cleanup
>
>
> BTW, I noticed the following fix is needed for some .configs that
> I found with randconfig builds, that's only in the cleanup branch
> as I already merged in iomap and pushed it out. Should not affect
> your patches though.
>
BTW, all these includes need to get removed. I'll add a fix to my series
unless you already have fixes:
arch/arm/mach-omap1/sleep.S:#include <mach/io.h>
arch/arm/mach-omap1/sram.S:#include <mach/io.h>
arch/arm/plat-omap/include/plat/sdrc.h:#include <mach/io.h>
drivers/media/video/davinci/vpbe_osd.c:#include <mach/io.h>
drivers/media/video/davinci/vpbe_venc.c:#include <mach/io.h>
drivers/video/omap2/vrfb.c:#include <mach/io.h>
Rob
> Regards,
>
> Tony
>
>
> From: Tony Lindgren <tony@xxxxxxxxxxx>
> Date: Tue, 28 Feb 2012 17:28:09 -0800
> Subject: [PATCH] ARM: OMAP2+: Fix L4_EMU_34XX_BASE error after iomap changes
>
> With the introduction of iomap changes platform init code
> fails for emu.c if CONFIG_OMAP3_EMU is selected:
>
> arch/arm/mach-omap2/emu.c:35:8: error:
> 'L4_EMU_34XX_BASE' undeclared here (not in a function)
>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
>
> --- a/arch/arm/mach-omap2/emu.c
> +++ b/arch/arm/mach-omap2/emu.c
> @@ -21,6 +21,8 @@
> #include <linux/clk.h>
> #include <linux/err.h>
>
> +#include <mach/hardware.h>
> +
> #include "iomap.h"
>
> MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
