* Hiremath, Vaibhav <hvaibhav@xxxxxx> [120129 23:59]: > On Fri, Jan 27, 2012 at 11:02:01, Hiremath, Vaibhav wrote: > > On Fri, Jan 27, 2012 at 05:55:43, Tony Lindgren wrote: > > > * Vaibhav Hiremath <hvaibhav@xxxxxx> [120122 23:26]: > > > > Add missing break statement in the function omap3xxx_check_revision. > > > > > > > > The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros > > > > and detection support], removed the 'break' statement from the function > > > > omap3xxx_check_revision(), resulting into wrong omap/cpu_revision > > > > initialization for AM335x devices. > > > > > > Looks like this is already fixed, can you please verify with > > > v3.3-rc1? > > > > > Tony, > > > > I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required. > > > > I can still see, > > > > 394 } > > 395 break; > > 396 case 0xb944: > > 397 omap_revision = AM335X_REV_ES1_0; > > 398 cpu_rev = "1.0"; > > 399 case 0xb8f2: > > 400 switch (rev) { > > > > > Tony, > > Can this be merged? I can still see "break" statement missing in the latest > linux-omap/master branch. OK thanks applying into fixes for the -rc cycle. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html