On 02/29/2012 08:48 AM, Tomi Valkeinen wrote: > panel-dvi uses i2c, but the Kconfig didn't have dependency on I2C. Add > it. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > --- > drivers/video/omap2/displays/Kconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/omap2/displays/Kconfig b/drivers/video/omap2/displays/Kconfig > index 74d29b5..408a992 100644 > --- a/drivers/video/omap2/displays/Kconfig > +++ b/drivers/video/omap2/displays/Kconfig > @@ -12,7 +12,7 @@ config PANEL_GENERIC_DPI > > config PANEL_DVI > tristate "DVI output" > - depends on OMAP2_DSS_DPI > + depends on OMAP2_DSS_DPI && I2C It's just a matter of taste, but are you sure you want to "depend" on it and not "select" it? Other drivers tend to use select for I2C, for me it doesn't really matter. Best regards, Florian Tobias Schandinat > help > Driver for external monitors, connected via DVI. The driver uses i2c > to read EDID information from the monitor. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
