Re: [PATCH] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 24, 2012 at 11:38:09AM +0200, Tero Kristo wrote:
> On Thu, 2012-02-23 at 15:34 +0000, Mark Brown wrote:

> > Since you're using min_uV as the "register value" you probably ought to
> > be returning that as the selector too and supplying a list_voltage()
> > which just passes the selector back in case something tries to use it
> > and gets confused.

> I was thinking at some point about adding a list_voltage for these
> regulators, however I dropped that idea, because the regulators can
> support a range of voltages (from min to max) with some stepping value.
> But... if you propose that the list_voltage would just return the
> current voltage back, wouldn't that also potentially confuse the user
> more, as it can only see the single voltage and nothing else, maybe
> making it to think that the regulator can only support one voltage
> level?

Yes, that'd be completely broken.  You'd need to just return the
selector back which would tell them that they had voltage control in
microvolt steps.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux