On Thu, Feb 23, 2012 at 6:51 PM, Tero Kristo <t-kristo@xxxxxx> wrote: > From: Vishwanath BS <vishwanath.bs@xxxxxx> > > IO Daisychain feature has to be triggered whenever there is a change in > device's mux configuration (See section 3.9.4 in OMAP4 Public TRM vP). > > Now devices can idle independent of the powerdomain, there can be a > window where device is idled and corresponding powerdomain can be > ON/INACTIVE state. In such situations, since both module wake up is > enabled at padlevel as well as io daisychain sequence is triggered, > there will be 2 PRCM interrupts (Module async wake up via swakeup and > IO Pad interrupt). But as PRCM Interrupt handler clears the Module > Padlevel WKST bit in the first interrupt, module specific interrupt > handler will not triggered for the second time > > Also look at detailed explanation given by Rajendra at > http://www.spinics.net/lists/linux-serial/msg04480.html > > Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx> > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > --- > arch/arm/mach-omap2/omap_hwmod.c | 9 +++++++-- > arch/arm/mach-omap2/pm.c | 7 +++++++ > arch/arm/mach-omap2/pm.h | 1 + > 3 files changed, 15 insertions(+), 2 deletions(-) > [...] > > diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c > index 1881fe9..e8b54eb 100644 > --- a/arch/arm/mach-omap2/pm.c > +++ b/arch/arm/mach-omap2/pm.c > @@ -25,6 +25,7 @@ > #include "clockdomain.h" > #include "pm.h" > #include "twl-common.h" > +#include "prm44xx.h" > > static struct omap_device_pm_latency *pm_lats; > > @@ -64,6 +65,12 @@ static void omap2_init_processor_devices(void) > } > } > > +void omap_trigger_wuclk_ctrl(void) > +{ > + if (cpu_is_omap44xx()) can we avoid above check to make it generic so that even OMAP5 can use this code without any change. Some flag might do the trick. Rest of the patch looks fine to me. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
