Re: [RFC 1/1] omap3: PM: MPU and CORE should stay awake if there is CAM domain ACTIVE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jan 27, 2012 at 11:00 AM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> MPU and CORE should stay awake if there is CAM domain ACTIVE. This is
> because that module doesn't have wake-up capability.
>
> The original patch was written by Jouni Högander in 2008 and this is the
> last part left of it which is not in upstream yet.
>
> I wonder if the approach taken in the patch is valid these days;
> nevertheless it seems to do the job...
The code in the function omap3_enter_idle_bm from
arch/arm/mach-omap2/cpuidle34xx.c is doing exactly the same thing: it
is choosing the cpuidle safe_state if the CAM power domain is active.

Please note that this only works if CPU_IDLE is selected, which is
needed to reach any decent low power mode.

Regards,
Jean

>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> ---
>  arch/arm/mach-omap2/pm34xx.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index fc69875..4ef682d 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -295,6 +295,9 @@ void omap_sram_idle(void)
>        pwrdm_clear_all_prev_pwrst(core_pwrdm);
>        pwrdm_clear_all_prev_pwrst(per_pwrdm);
>
> +       if (pwrdm_read_pwrst(cam_pwrdm) == PWRDM_POWER_ON)
> +               clkdm_deny_idle(mpu_pwrdm->pwrdm_clkdms[0]);
> +
>        mpu_next_state = pwrdm_read_next_pwrst(mpu_pwrdm);
>        switch (mpu_next_state) {
>        case PWRDM_POWER_ON:
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux