On Fri, Jan 13, 2012 at 1:49 PM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Fri, Jan 13, 2012 at 9:46 PM, Rob Clark <rob@xxxxxx> wrote: >> On Fri, Jan 13, 2012 at 1:41 PM, Rob Clark <rob.clark@xxxxxxxxxx> wrote: >>> +/* files from staging that contain platform data structure definitions */ >>> +#include "../../../drivers/staging/omapdrm/omap_priv.h" >>> +#include "../../../drivers/staging/omapdrm/omap_dmm_tiler.h" >> >> btw, I'm not a huge fan of doing #includes this way, so if someone has >> a better suggestion (given that staging drivers should not have >> headers outside of drivers/staging) please let me know > > Move those structs to /arch/arm/plat-omap/drm.h? Can I do that? Maybe it depends of if you consider those structs as part of the driver, or part of the platform? I guess that looks like how it was handled for dspbridge, so maybe that means it is a suitable precedent.. BR, -R > -- > Felipe Contreras > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html