On Fri, 2011-12-30 at 04:04 +0100, Janusz Krzysztofik wrote: > This functionality has just been implemented in the cx20442 codec > driver, no need to keep it here duplicated. > > Once done, remove the no longer used AMS_DELTA_LATCH2_MODEM_NRESET > symbol from the board header file and a call to the regulator_toggle() > helper function from the old API wrapper found in the board file. While > being at it, simplify the way the modem .pm callback handles the > regulator, and drop that no longer used helper function and its related > consumer setup elements completely. > > Depends on patch 3/4 "ARM: OMAP1: ams-delta: update the modem to use > regulator API" > > Signed-off-by: Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> > --- > Changes against initial version: > * don't move consumer setup elements, now named to indicated their > modem related purpose, down the file, > * don't track the regulator enavble/disable state, compare new target > power state with the old one instead; thanks to Mark Brown for > suggesting this simplification, > * actually drop all references to AMS_DELTA_LATCH2_MODEM_NRESET. > > arch/arm/mach-omap1/board-ams-delta.c | 42 +++----------------- > arch/arm/plat-omap/include/plat/board-ams-delta.h | 1 - > sound/soc/omap/ams-delta.c | 32 ---------------- > 3 files changed, 7 insertions(+), 68 deletions(-) I tried to apply against ASoC but it failed with the omap files. It may be better for this patch to go via Tony. 2/4 applies and builds ok, but if there is a runtime dependency on the rest it should go via Tony too. Thanks Liam -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
