Re: [PATCH 1/1] omap3: add definition for CONTROL_CAMERA_PHY_CTRL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tony and Paul,

On Wed, Dec 14, 2011 at 05:14:16PM +0200, Sakari Ailus wrote:
> The register is used to configure the behaviour of the CSI-2 and CCP-2
> receivers. This register is available only in OMAP3630.
> 
> The original patch was submitted by Vimarsh Zutshi.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> ---
>  arch/arm/mach-omap2/control.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/control.h b/arch/arm/mach-omap2/control.h
> index d4ef75d..6a26a0d 100644
> --- a/arch/arm/mach-omap2/control.h
> +++ b/arch/arm/mach-omap2/control.h
> @@ -183,6 +183,7 @@
>  #define OMAP3630_CONTROL_FUSE_OPP120_VDD1       (OMAP2_CONTROL_GENERAL + 0x0120)
>  #define OMAP3630_CONTROL_FUSE_OPP50_VDD2        (OMAP2_CONTROL_GENERAL + 0x0128)
>  #define OMAP3630_CONTROL_FUSE_OPP100_VDD2       (OMAP2_CONTROL_GENERAL + 0x012C)
> +#define OMAP3630_CONTROL_CAMERA_PHY_CTRL	(OMAP2_CONTROL_GENERAL + 0x02f0)

I assume this patch hasn't gone anywhere yet which might be good. While the
definition of this register would appear to belong to this file, it is being
included from the OMAP 3 ISP driver, which only uses it if it's running on
the 3630. The problem is that control.h isn't apparently intended to be
included except locally and I didn't find a suitable file under include/mach
to put this definition either. Currently this file is being included by the
ISP driver with an explicit path.

Do you have an insight how this could be handled better?

Kind regards,

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx	jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux