> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Tuesday, December 20, 2011 5:21 AM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; Hilman, Kevin > Subject: Re: [PATCH-V3 2/2] arm:omap: cleanup & split > omap2/3/4_check_revision function > > * Vaibhav Hiremath <hvaibhav@xxxxxx> [111219 01:48]: > > This patch doesn't change functionality or behavior of the code > > execution; it barely cleans up the code and splits into SoC > > specific implementation for Rev ID and feature detection. > > Thanks, looks good now and allows further clean-up later on. > I'll apply these into soc-part2 branch. > Thanks Tony. Thanks, Vaibhav > > @@ -495,37 +498,6 @@ static void __init omap4_check_revision(void) > > } > > > > /* > > - * Try to detect the exact revision of the omap we're running on > > - */ > > -void __init omap2_check_revision(void) > > -{ > > - /* > > - * At this point we have an idea about the processor revision set > > - * earlier with omap2_set_globals_tap(). > > - */ > > - if (cpu_is_omap24xx()) { > > - omap24xx_check_revision(); > > - } else if (cpu_is_omap34xx()) { > > - omap3_check_revision(); > > - > > - /* TI81XX doesn't have feature register */ > > - if (!cpu_is_ti81xx()) > > - omap3_check_features(); > > - else > > - ti81xx_check_features(); > > - > > - omap3_cpuinfo(); > > - return; > > - } else if (cpu_is_omap44xx()) { > > - omap4_check_revision(); > > - omap4_check_features(); > > - return; > > - } else { > > - pr_err("OMAP revision unknown, please fix!\n"); > > - } > > -} > > - > > Nice that we can get rid of this function now :) > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
