* Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> [111219 16:46]: > On Tuesday 20 of December 2011 at 02:04:46, Tony Lindgren wrote: > > * Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> [111219 16:28]: > > > On Tuesday 20 of December 2011 at 01:06:00, Tony Lindgren wrote: > > > > > > > > This part especially looks like it really should be just a regular > > > > device driver under drivers/ somewhere. > > > > > > I really don't understand what kind of a driver you might mean here. > > > > > > The latch_gpios[] table is initially filled with all latch1 and latch2 > > > GPIO pins in order to register and initialize them from the board file > > > until they are handled by respective existing device drivers (leds, > > > nand, lcd, serio, serial8250, asoc) instead of those drivers accessing > > > the latches with those old ams_delta_latch[12]_write() functions. That > > > table will get almost empty after the transision process is completed, > > > holding only pins not used by any drivers / connected to unsued devices, > > > in order to initialize them from the board file for power saving > > > purposes. A separate driver for the purpose of initializing a few GPIO > > > pins seems an overkill. > > > > OK maybe update the comments a bit to describe how that table will > > mostly disappear? It's not obvious from glancing over this patch > > series :) > > To be sure, do you mean in-line comments? Or the changelog message? Just the changelog. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
