Hi Ricardo, On Fri, 2011-12-16 at 01:03 -0600, Ricardo Neri wrote: > The function hdmi_audio_trigger is a callback used by ASoC to stop/start > HDMI audio. Also, it does not perform IP-specific configuration directly. > Hence, it should be placed in the general portion of the HDMI driver, > along with the other ASoC callbacks. > > Signed-off-by: Ricardo Neri <ricardo.neri@xxxxxx> > --- > drivers/video/omap2/dss/hdmi.c | 31 ++++++++++++++++++++++++++++ > drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c | 32 ----------------------------- > drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h | 2 - > 3 files changed, 31 insertions(+), 34 deletions(-) > > diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c > index a0e254e..5c93041 100644 > --- a/drivers/video/omap2/dss/hdmi.c > +++ b/drivers/video/omap2/dss/hdmi.c > @@ -554,6 +554,37 @@ void omapdss_hdmi_display_disable(struct omap_dss_device *dssdev) > #if defined(CONFIG_SND_OMAP_SOC_OMAP4_HDMI) || \ > defined(CONFIG_SND_OMAP_SOC_OMAP4_HDMI_MODULE) > > +int hdmi_audio_trigger(struct snd_pcm_substream *substream, int cmd, > + struct snd_soc_dai *dai) This should be static. Otherwise the patch set looks fine to me. Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
