> -----Original Message----- > From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] > Sent: Saturday, December 17, 2011 6:58 AM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx; Hilman, Kevin > Subject: Re: [PATCH-V2] arm:omap: cleanup & split omap2/3/4_check_revision > function > > * Vaibhav Hiremath <hvaibhav@xxxxxx> [111216 03:32]: > > This patch doesn't change functionality or behavior of the code > > execution; it barely cleans up the code and splits into SoC > > specific implementation for Rev ID and feature detection. > > > > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx> > > --- > > Changes from V1: > > - Incorporated suggessions from Tony to split the function > > Thanks for working on this, the end result looks much better. > > Can you please split it into two or more patches as this patch > is pretty much unreadable unfortunately? > > Maybe add empty check_revision functions first or something > like that so the diff stays readable? > > Also.. > > > +static void __init omap3_cpuinfo(const char *cpu_rev) > > +{ > > + const char *cpu_name; > > ..the _cpuinfo functions can now be void as the cpu_rev > is already set globally? > Thanks Tony, I will incorporate all the changes (split the patch) and submit the patch series now. Thanks, Vaibhav > Regards, > > Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
