Re: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rajendra,

Just one minor comment if you plan to repost.

On 12/14/2011 12:55 PM, Rajendra Nayak wrote:
Pass minimal data needed for console boot, from dt, for
OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the
static initialization from generic board file.

Acked-by: Rob Herring<rob.herring@xxxxxxxxxxx>
Signed-off-by: Rajendra Nayak<rnayak@xxxxxx>

Tested-by: Benoit Cousson <b-cousson@xxxxxx>

  arch/arm/boot/dts/omap3.dtsi        |   31 +++++++++++++++++++++++++++++++
  arch/arm/boot/dts/omap4.dtsi        |   28 ++++++++++++++++++++++++++++
  arch/arm/mach-omap2/board-generic.c |    1 -
  3 files changed, 59 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index d202bb5..216c331 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -13,6 +13,13 @@
  / {
  	compatible = "ti,omap3430", "ti,omap3";

+	aliases {
+		serial0 =&uart1;
+		serial1 =&uart2;
+		serial2 =&uart3;
+		serial3 =&uart4;
+	};
+
  	cpus {
  		cpu@0 {
  			compatible = "arm,cortex-a8";
@@ -59,5 +66,29 @@
  			interrupt-controller;
  			#interrupt-cells =<1>;
  		};
+
+		uart1: serial@0x4806a000 {

Could you get rid of the 0x prefix for consistency?
This is applicable for the omap4.dtsi as well.

Thanks,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux