On Fri, 2011-12-09 at 15:13 -0800, Kevin Hilman wrote: > Tero Kristo <t-kristo@xxxxxx> writes: > > > OMAP mux now provides a service routine to parse pending wakeup events > > and to call registered ISR whenever active wakeups are detected. > > Good. > > > This routine is called directly from PRCM interrupt handler. > > I think this comment is out of date with the code, since you're now > using a shared IRQ and the interrupt is directly called from the IRQ > core. > > I'd update the changelog here just commenting on what this IRQ is shared > with, and how the interrupts are shared. > > Also, a question on optimization. For every IO wakeup, this will go > through the list of *all* enabled hwmods. This could be pretty expensive > with lots of wakeups. Maybe we should have another flag for hwmods that > have wakeups enabled so walking the list of potential wakeup-capable > hwmods will be as fast as possible. Optimization of this code is sure possible, and probably even desirable. In some of the earlier sets I had a separate list for the pad scan, but it was dropped out due to some comments. It would be possible to add either a separate list for these within omap_hwmod / mux, or either a flag which checks for enabled io wakeups. -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
