Re: [PATCHv4 01/15] OMAP3+: PM: VP: use uV for max and min voltage limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-12-09 at 10:07 -0800, Kevin Hilman wrote:
> Tero Kristo <t-kristo@xxxxxx> writes:
> 
> > From: Nishanth Menon <nm@xxxxxx>
> >
> > Every PMIC has it's own eccentricities, For example, one of the
> > PMIC has MSB set to 1 for a specific function - voltage enable!
> > using an hardcoded value specific for TWL when copied over to
> > such an implementation causes the system to crash as the MSB bit
> > was 0 and the voltage got disabled!.
> >
> > Instead we use actual values and depend on the convertion routines
> > to abstract out the eccentricities of each PMIC.
> >
> > With this, we can now move the voltages to a common location in
> > voltage.h as they are no longer dependent on PMICs and expect the
> > PMIC's conversion routines to set a cap if the voltage is out of
> > reach for the PMIC.
> 
> Nice.
> 
> > Reported-by: Jon Hunter <jon-hunter@xxxxxx>
> > Signed-off-by: Nishanth Menon <nm@xxxxxx>
> > Signed-off-by: Vishwanath BS <vishwanath.bs@xxxxxx>
> 
> Also needs your sign-off, since you're on the delivery path now.

Oh sorry about that, I'll add it.

-Tero


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux