Re: [PATCHv10 04/14] omap: prm: add support for suspend prepare and finish callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tero Kristo <t-kristo@xxxxxx> writes:

> These are needed because runtime PM is disabled during suspend, and
> it is bad if we get interrupts from the PRCM chain handler during it.
> This patch masks all the PRCM interrupt events, but does not ack them,
> if an interrupt is received during suspend. Once suspend->finish
> is called, all the masked events will be re-enabled, which causes
> immediate PRCM interrupt and handles the postponed event.
>
> The suspend prepare and complete  callbacks will be called from pm34xx.c /
> pm44xx.c files in the following patches.

You might just update this changelog to clarify why you're using the the
driver-specific prepare & complete terminology whereas this code is
using begin/finish hooks as part of platform_pm_ops.

IOW, state that this will soon be becoming a real driver, so you're
using the driver terminology.

Also note that subject uses prepare & finish instead of prepare & complete.

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux