On Fri, Dec 9, 2011 at 3:34 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> + ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
...
>> EXPORT_SYMBOL_GPL(omap_dm_timer_request);
>
> This does not seem right.. It seems that you're hardcoding the source
> clock to 32 KiHz clock while other sources are available too?
Agree, but... (below)
>> + ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
...
> And here too?
Agree but that is the default behavior set by dm timer framework:
@@ -134,22 +134,13 @@ static void omap_dm_timer_reset(struct
omap_dm_timer *timer)
int omap_dm_timer_prepare(struct omap_dm_timer *timer)
{
...
- ret = omap_dm_timer_set_source(timer, OMAP_TIMER_SRC_32_KHZ);
...
All clocks requested are set to 32 KHz first, even with the current
approach, there exists another API to set a new source.
To be honest I don't know why the clocks are set to 32 KHz first,
maybe the default call path for users should be:
omap_dm_timer_request
omap_dm_timer_set_source (new explicit call)
omap_dm_timer_start
And remove setting the source to 32 KHz by default in omap_dm_timer_request.
Regards,
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
