Hi Laurent, Thanks for the review. On Thu, Dec 1, 2011 at 11:24 AM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > Hi Sergio, > > On Thursday 01 December 2011 01:14:51 Sergio Aguirre wrote: >> The define should be the result of 1 << Bit number. >> >> Bit number for GPOCTL.GPO3 field is 2, which results >> in 0x4 value. >> >> Signed-off-by: Sergio Aguirre <saaguirre@xxxxxx> >> --- >> include/linux/mfd/twl6040.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/include/linux/mfd/twl6040.h b/include/linux/mfd/twl6040.h >> index 2463c261..2a7ff16 100644 >> --- a/include/linux/mfd/twl6040.h >> +++ b/include/linux/mfd/twl6040.h >> @@ -142,7 +142,7 @@ >> >> #define TWL6040_GPO1 0x01 >> #define TWL6040_GPO2 0x02 >> -#define TWL6040_GPO3 0x03 >> +#define TWL6040_GPO3 0x04 > > What about defining the fields as (1 << x) instead then ? I thought about that, but I guess I just wanted to keep it consistent with the rest of the file. Maybe I can create a separate patch for changing all these bitwise flags to use BIT() macros instead. Thanks and Regards, Sergio > >> >> /* ACCCTL (0x2D) fields */ > > -- > Regards, > > Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
