"Mahaveer, Vishal" <vishalm@xxxxxx> writes: > Hilman, Kevin wrote: >> >> No. >> >> You want it on only >> >> 1) if the connectivity chip is present, *and* >> 2) BT, WLAN, FM or GPS are being used. >> >> The current patch assumes that a connectivity chip is present >> whenever the TWL is present, which may be true on the platform you're >> currently working on, but is not true in general. >> >> And, even if it were present, for power reasons the regulator should >> be enabled only when it's needed, not because it might be needed. >> That means that the device-specific (or board specific) code should >> be configuring the regulators used for the various modules so the >> drivers can request the regulators when they're needed. >> > > Will it make more sense to move clk32 regulator initialization to > board-xxx files of platforms which has the connectivity chip? Yes, initialization should be done only when connectivity chip is present. But more importantly, it's the usage of the regulator API that is important. My primary objection to this patch is the use of 'always on', where the drivers/devices that depend on this regulator are the ones that should be requesting it to be on using the regulator API. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
