RE: [PATCH 1/1] OMAP: TWL: set clk32kg regulator on

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hilman, Kevin wrote:
> 
> No.
> 
> You want it on only
> 
> 1) if the connectivity chip is present, *and*
> 2) BT, WLAN, FM or GPS are being used.
> 
> The current patch assumes that a connectivity chip is present
> whenever the TWL is present, which may be true on the platform you're
> currently working on, but is not true in general.  
> 
> And, even if it were present, for power reasons the regulator should
> be enabled only when it's needed, not because it might be needed. 
> That means that the device-specific (or board specific) code should
> be configuring the regulators used for the various modules so the
> drivers can request the regulators when they're needed.    
> 
> Kevin

Will it make more sense to move clk32 regulator initialization to board-xxx files of platforms which has the connectivity chip?

- Vishal--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux