Hi Vaibhav,
On 11/07/11 14:58, Vaibhav Hiremath wrote:
> Fixes below compilation error -
>
> CC arch/arm/mach-omap2/hwspinlock.o
> cc1: warnings being treated as errors
> In file included from arch/arm/mach-omap2/hwspinlock.c:22:0:
> include/linux/hwspinlock.h: In function '__hwspin_unlock':
> include/linux/hwspinlock.h:121:2: error: 'return' with a value, in function
> returning void
> make[1]: *** [arch/arm/mach-omap2/hwspinlock.o] Error 1
> make: *** [arch/arm/mach-omap2] Error 2
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> ---
> include/linux/hwspinlock.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/hwspinlock.h b/include/linux/hwspinlock.h
> index 08a2fee..192710a 100644
> --- a/include/linux/hwspinlock.h
> +++ b/include/linux/hwspinlock.h
> @@ -118,7 +118,7 @@ int __hwspin_trylock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
> static inline
> void __hwspin_unlock(struct hwspinlock *hwlock, int mode, unsigned long *flags)
> {
> - return 0;
> + return;
Isn't it better to just remove this line?
> }
>
> static inline int hwspin_lock_get_id(struct hwspinlock *hwlock)
--
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
