On Fri, Nov 04, 2011 at 04:01:04PM +0000, Mohammed, Afzal wrote: > On Fri, Nov 04, 2011 at 20:55:59, Mark Brown wrote: > > That doesn't really clarify things - the question is why the number of > > voltages we can set is three times a constant called _NUM_VOLTS? > _NUM_VOLTS is the number of voltage steps. > I will try to come up with a better explanation or rather the > right solution, new to regulator world as of now. So that definitely seems wrong then - n_voltages is supposed to be the number of voltages that can be selected so if the regulator supports _NUM_VOLTS steps then I'd expect to see that constant used directly. Otherwise I'd suggest that the magic number needs a #define. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
