On Fri, Nov 04, 2011 at 02:26:05PM +0000, Mohammed, Afzal wrote: > Hi Brown, Ahem. > On Fri, Nov 04, 2011 at 19:34:22, Mark Brown wrote: > > On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote: > > > if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) { > > > pmic->desc[i].ops = &tps65910_ops_dcdc; > > > + pmic->desc[i].n_voltages = VDD1_2_NUM_VOLTS * 3; > > This looks suspicous - what's the * 3 about? > Gain in voltage possible is x1, 0x2 & 0x3, I am shaky > about this change, but voltage could be changed with this, That doesn't really clarify things - the question is why the number of voltages we can set is three times a constant called _NUM_VOLTS? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html