On Sat, Oct 29, 2011 at 12:47:57AM +0200, Sascha Hauer wrote: > My main concern with the fixed regulator is that it needs quite much > boilerplate code just to say that we have no regulator at all for a > given device. That could also be handled with a helper function which > registers a fixed regulator and only takes the regulator_consumer_supply > as an argument. Would that be ok for you? All you're actually doing in this code is adding a function to register a new type of regulator which is exactly equivalent to what the existing regulators provide - there's nothing particularly wrong with the helper function but defining an entirely new regulator type for it doesn't seem useful. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html