On Fri, Oct 28, 2011 at 11:59:31PM +0200, Mark Brown wrote: > On Fri, Oct 28, 2011 at 10:26:58PM +0200, Sascha Hauer wrote: > > > drivers/regulator/Makefile | 2 +- > > drivers/regulator/dummy-supply.c | 88 +++++++++++++++++++++++++++++++++++++ > > We already have a dummy regulator driver and a fixed voltage regulator > driver, we shouldn't be adding a third implementation of the same thing. > Just use the fixed voltage regulator for this. I explained in my mail why I think that the current implementation of the dummy regulator is not suitable for things apart from debugging. My main concern with the fixed regulator is that it needs quite much boilerplate code just to say that we have no regulator at all for a given device. That could also be handled with a helper function which registers a fixed regulator and only takes the regulator_consumer_supply as an argument. Would that be ok for you? Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
