On Wed, Oct 12, 2011 at 2:31 AM, Kevin Hilman <khilman@xxxxxx> wrote: > "Govindraj.R" <govindraj.raja@xxxxxx> writes: > >> Move the errata handling mechanism from serial.c to omap-serial file >> and utilise the same func in driver file. >> >> Errata i202, i291 are moved to be handled with omap-serial >> Moving the errata macro from serial.c file to driver header file >> as from on errata will be handled in driver file itself. >> >> Corrected errata id from chapter reference 2.15 to errata id i291. >> >> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx> >> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> > > The errata handling for i291 is moved from device code to driver code > but it's functionality is also changed (but not described.) > > In the current mainline code, The workaround for i291 is done whenever > UART clocks are about to be cut. When the clocks are (re)enabled, the > device is put back into no-idle. > > This patch puts the device into force-idle just before the idle/suspend > transistion, but never puts it back into no-idle. So after the first > idle/suspend transition, the IP remains in force-idle forever. I don't > think that's what we want. > I was thinking no_idle will be done once we re-enable uart clocks from omap_device_enable but that's not the case looking into the code. Will correct it will add no_idle call from .runtime_resume as done early where we put into no_idle(sysc) while enabling the clocks. -- Thanks, Govindraj.R -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
