On Tue, Oct 11, 2011 at 5:26 AM, Kevin Hilman <khilman@xxxxxx> wrote: > "Govindraj.R" <govindraj.raja@xxxxxx> writes: > >> Adapts omap-serial driver to use pm_runtime API's. >> >> Use runtime runtime API's to handle uart clocks and obtain >> device_usage statics. Set runtime API's usage to irq_safe so that >> we can use get_sync from irq context. Auto-suspend for port specific >> activities and put for reg access. Use device_may_wakeup to check >> whether uart has wakeup capabilities and then enable uart runtime >> usage for the uart. > > OK. Current patch should do only this part. The rest should be > separate patches with their own descriptive changelogs. > Yes, started splitting them. >> Removing save_context/restore_context functions from serial.c >> Adding context restore to .runtime_suspend and using reg values from port >> structure to restore the uart port context based on context_loss_count. >> Maintain internal state machine using wakeups_enabled field for avoiding >> repeated enable/disable of uart port wakeup mechanism. > > This part should be a separate patch that follows. > okay, >> Remove omap_uart_disable_wakeup and modify omap_uart_enable_wakeup >> to accept pdev and bool value to enable/disable the uart wakeup mechanism >> after uart clock's are cut. >> >> omap_hwmod_enable_wakeup is used to set >> pad wakeup for the uarts. PM_WKEN reg values are left to default. >> Removed omap_uart_enable/disable_clocks in serial.c now clock handling >> done with runtime API's. > > As stated in previous reviews, this wakeup enable/disable needs more > description as the functionality is changing compared to current code. > > Current version modifies wakeup enable/disable at both power-domain > level (PM_WKEN) and at the IO ring. > > Updated version modifies wakeups at module-level (SYSCONFIG) and at IO > ring using omap_hwmod_enable_wakeup() > > IMO, the updated version makes more sense, but needs a description as to > why that change in functionality will have equivalent results compared > to the existing one. > Okay, >> By default uart autosuspend delay is set to -1 to avoid character loss >> if uart's are autoidled and woken up on rx pin. > > OK, good. > >> After boot up UART's can be autoidled by setting autosuspendi delay from sysfs. >> >> echo 3000 > /sys/devices/platform/omap/omap_uart.X/power/autosuspend_delay_ms >> X=0,1,2,3 for UART1/2/3/4. Number of uarts available may vary across omap_soc. >> >> Acked-by: Alan Cox <alan@xxxxxxxxxxxxxxx> >> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> > > Kevin > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
