Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul,

On 10/11/2011 2:40 AM, Paul Walmsley wrote:
Hi

and some comments on this one ...

On Thu, 6 Oct 2011, Keshava Munegowda wrote:

[...]

+static struct omap_hwmod_ocp_if omap44xx_l4_cfg__usb_tll_hs = {
+	.master		=&omap44xx_l4_cfg_hwmod,
+	.slave		=&omap44xx_usb_tll_hs_hwmod,
+	.addr		= omap44xx_usb_tll_hs_addrs,
+	.user		= OCP_USER_MPU | OCP_USER_SDMA,
+};

This one has the .master pointing to something reasonable, but is missing
a .clk entry.

In that case, there is only an interface clock and a couple of optional clocks, that why I did not populate the main_clk.

IIRC, we decided to not duplicate the iclk into the main_clk in case of module that are using only the interface clock as their functional clock.

Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux