On Tue, Oct 11, 2011 at 4:00 AM, Kevin Hilman <khilman@xxxxxx> wrote: > "Govindraj.R" <govindraj.raja@xxxxxx> writes: > >> Currently we use a shared irq handler to identify uart activity and then >> trigger a timer. > > OK. > >> Based the timeout value set from sysfs the timer used to expire. > > Please re-phrase as I'm not sure what is being said here. > >> If no uart-activity was detected timer-expiry func sets can_sleep >> flag. Based on this we will disable the uart clocks in idle path. >> >> Since the clock gating mechanism is outside the uart driver, we currently >> use this mechanism. In preparation to runtime implementation for omap-serial >> driver we can cleanup this mechanism and use runtime API's to gate uart clocks. >> >> Also remove timer related info from local uart_state struct and remove >> the code used to set timeout value from sysfs. Remove un-used function >> omap_uart_check_wakeup. >> >> Signed-off-by: Govindraj.R <govindraj.raja@xxxxxx> > > The patch itself fine, and is a well-neede cleanup, but changelog > (especially the first part) does not read well. > Okay, Will Correct. -- Thanks. Govindraj.R -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
