Re: [PATCH 2/6] OMAP4: Clock: Associate clocks for OMAP temperature sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 23, 2011 at 11:28 AM, Paul Walmsley <paul@xxxxxxxxx> wrote:
> On Fri, 23 Sep 2011, J, KEERTHY wrote:
>
>> On Fri, Sep 23, 2011 at 10:48 AM, Paul Walmsley <paul@xxxxxxxxx> wrote:
>> > On Thu, 22 Sep 2011, Keerthy wrote:
>> >
>> >> ---
>> >>  arch/arm/mach-omap2/clock44xx_data.c |    4 ++--
>> >>  1 files changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
>> >> index 946bf04..c51e513 100644
>> >> --- a/arch/arm/mach-omap2/clock44xx_data.c
>> >> +++ b/arch/arm/mach-omap2/clock44xx_data.c
>> >> @@ -3185,9 +3185,9 @@ static struct omap_clk omap44xx_clks[] = {
>> >>       CLK(NULL,       "aes2_fck",                     &aes2_fck,      CK_443X),
>> >>       CLK(NULL,       "aess_fck",                     &aess_fck,      CK_443X),
>> >>       CLK(NULL,       "bandgap_fclk",                 &bandgap_fclk,  CK_443X),
>> >> -     CLK(NULL,       "bandgap_ts_fclk",              &bandgap_ts_fclk,       CK_446X),
>> >> +     CLK("omap4460plus_scm.0",       "fck",          &bandgap_ts_fclk,       CK_446X),
>> >>       CLK(NULL,       "des3des_fck",                  &des3des_fck,   CK_443X),
>> >> -     CLK(NULL,       "div_ts_ck",                    &div_ts_ck,     CK_446X),
>> >> +     CLK("omap4460plus_scm.0",       "div_ck",                       &div_ts_ck,     CK_446X),
>> >
>> > Clearly this device is incorrectly named.  You're setting up a clkdev
>> > entry that's marked as being valid for OMAP4430, but your device is called
>> > "omap4460plus_scm".  They can't both be right...
>>
>> This is addressed in Patch 06.
>
> How does patch 6 address it?

I am not sure i interpreted the comment right. These clock nodes are specific to
OMAP4460 and are tagged CK_446X hence the device name "omap4460plus_scm.0"

>
>
> - Paul



-- 
Regards and Thanks,
Keerthy
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux