Re: [PATCH 2/6] OMAP4: Clock: Associate clocks for OMAP temperature sensor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Sep 2011, Keerthy wrote:

> div_ts_ck feeds only the temperature sensor functional clock
> and also has a clksel associated (for divider selection). Mapping this
> as well as the bandgap_ts_fclk the fclk of temperature sensor in clkdev table,
> so a clk_set_rate() on the div_ts_ck in the driver would have the effect of
> changing the temperature sensor clock rate indirectly.
> 
> Signed-off-by: Keerthy <j-keerthy@xxxxxx>
> Reviewed-by: Rajendra Nayak <rnayak@xxxxxx>
> Cc: tony@xxxxxxxxxxx
> Cc: paul@xxxxxxxxx 

Your cc's didn't take effect...

> ---
>  arch/arm/mach-omap2/clock44xx_data.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index 946bf04..c51e513 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -3185,9 +3185,9 @@ static struct omap_clk omap44xx_clks[] = {
>  	CLK(NULL,	"aes2_fck",			&aes2_fck,	CK_443X),
>  	CLK(NULL,	"aess_fck",			&aess_fck,	CK_443X),
>  	CLK(NULL,	"bandgap_fclk",			&bandgap_fclk,	CK_443X),
> -	CLK(NULL,	"bandgap_ts_fclk",		&bandgap_ts_fclk,	CK_446X),
> +	CLK("omap4460plus_scm.0",	"fck",		&bandgap_ts_fclk,	CK_446X),
>  	CLK(NULL,	"des3des_fck",			&des3des_fck,	CK_443X),
> -	CLK(NULL,	"div_ts_ck",			&div_ts_ck,	CK_446X),
> +	CLK("omap4460plus_scm.0",	"div_ck",			&div_ts_ck,	CK_446X),

Clearly this device is incorrectly named.  You're setting up a clkdev 
entry that's marked as being valid for OMAP4430, but your device is called 
"omap4460plus_scm".  They can't both be right...


>  	CLK(NULL,	"dmic_sync_mux_ck",		&dmic_sync_mux_ck,	CK_443X),
>  	CLK(NULL,	"dmic_fck",			&dmic_fck,	CK_443X),
>  	CLK(NULL,	"dsp_fck",			&dsp_fck,	CK_443X),
> -- 
> 1.7.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux