Hi Martin, On Monday 19 September 2011 08:10:19 martin@xxxxxxxxxxxxxxxxxxxxxx wrote: > On Sun, Sep 18, 2011 at 11:58:55PM +0200, Laurent Pinchart wrote: > > On Saturday 17 September 2011 11:34:57 Martin Hostettler wrote: > > > Adds board support for an MT9M032 based camera to omap3evm. > > > > > > Sigend-off-by: Martin Hostettler <martin@xxxxxxxxxxxxxxxxxxxxxx> > > > --- > > > > > > arch/arm/mach-omap2/Makefile | 1 + > > > arch/arm/mach-omap2/board-omap3evm-camera.c | 183 > > > > > > +++++++++++++++++++++++++++ 2 files changed, 184 insertions(+), 0 > > > deletions(-) > > > > > > create mode 100644 arch/arm/mach-omap2/board-omap3evm-camera.c > > > > > > Changes in V2: > > > * ported to current mainline > > > * Style fixes > > > * Fix error handling > > > > > > diff --git a/arch/arm/mach-omap2/Makefile > > > b/arch/arm/mach-omap2/Makefile index f343365..8ae3d25 100644 > > > --- a/arch/arm/mach-omap2/Makefile > > > +++ b/arch/arm/mach-omap2/Makefile > > > + return 0; > > > + > > > +err_8: > > > + gpio_free(EVM_TWL_GPIO_BASE + 8); > > > +err_2: > > > + gpio_free(EVM_TWL_GPIO_BASE + 2); > > > +err_vdsel: > > > + gpio_free(nCAM_VD_SEL); > > > +err: > > > + return ret; > > > +} > > > + > > > +device_initcall(camera_init); > > > > Please don't use device_initcall(), but call the function directly from > > the OMAP3 EVM init handler. Otherwise camera_init() will be called if > > OMAP3 EVM support is compiled in the kernel, regardless of the board the > > kernel runs on. > > Ok, will do. > In which header should the prototyp of that function go? Or can i just > add a prototyp to board-omap3evm.c directly? > I couldn't find anything that looked right, this is rather board specific > after all. You can either create arch/arm/mach-omap2/board-omap3evm.h or add the prototype to board-omap3evm.c. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
