On Fri, Sep 16, 2011 at 1:13 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Shilimkar, Santosh <santosh.shilimkar@xxxxxx> [110915 10:49]: >> On Thu, Sep 15, 2011 at 11:23 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: >> > >> > Please also include the errata in the description and set it up with >> > a Kconfig entry with something like ARM_ERRATA_XXXXXX or TI_ERRATA_XXXXXX. >> > >> Sure. >> It's a TI ERRATA. > > OK > >> > Also it would be best to apply this fix at the end of the PM series so >> > it is easier to verify the bug and potentially remove the hack if >> > a better fix is ever available. >> > >> As such order doesn't matter much because it can be removed either way >> even if it is in the beginning of the series with KCONFIG entry. >> >> But I can change the order if you prefer that way. > > Well it seems that it's the omap4_finish_suspend in this series that > can be used to trigger the bug, although the bug has been around for > few years. So then instead of mentioning random hangups you can have > a better description with something like "Patch xyz added PM idle > support for omap4, however bug 123 causes so and so. Fix the issue > with blah blah". > Sounds good . > Also, if you have some easy way to reproduce the bug maybe mention > that too? That would make it easy to verify if issue has been fixed. > There are some multimedia usecases where the bug was discovered but on mainline obviously we don't have that support. I will check with IP folks if any other simple test-case is possible to reproduce the issue and If I find one, will mention that. Thanks for the review. Regards Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
