Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> writes: > Mike, Kevin, > > On Thu, Jun 30, 2011 at 2:25 AM, Mike Turquette <mturquette@xxxxxx> wrote: >> From: Nishanth Menon <nm@xxxxxx> >> >> We have multiple interrupt status hidden in the PRM interrupt status >> reg. Make this handling generic to allow us to pull out LDO status such >> as those for ABB from it using the same data structure and indexing. We >> hence rename accordingly. > I am not sure that the rename is needed. > > Kevin, Nishant, what is your opinion? Rename is mostly fine. I think the patch is correct, since the interrupts are technically for the the whole PRM, not just the VP. However, I don't like the s/vp_id/irq_id/ in the APIs, because the APIs are intended to be VP specific. I'll likely pull/fold the parts I agree with into the original patch in my VP cleanup series Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
