On Fri, 9 Sep 2011, Santosh wrote: > On Friday 09 September 2011 12:49 PM, Thomas Gleixner wrote: > > > > The flag says: MASK ON SUSPEND and it does not imply that you don't > > need a wake function. There might be cases where you want to setup > > stuff in that function in order to have the wakeup happen on that > > interrupt line despite of the mask on suspend. > > > I see your point. > > > We either need a separate flag or a global dummy set_wake function in > > the core to avoid empty copies all over the place. > > > A flag is probably better since you mentioned that on some arch, there > might be need to have actual set_wake() handler. Or if the global > dummy can be over-ridden by platform, that's fine too. Global dummy would mean: int irq_set_wake_dummy(...) { return 0; } And you just add it to your chip, but either way I don't care whether it's a dummy function or a flag. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html