Re: [PATCH v2 04/10] OMAP4: DSS: HDMI: Move the common header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2011-09-02 at 10:45 +0530, K, Mythri P wrote:
> Hi,
> 
> On Thu, Sep 1, 2011 at 2:30 PM, Tomi Valkeinen <tomi.valkeinen@xxxxxx> wrote:
> > On Mon, 2011-08-29 at 11:44 +0530, mythripk@xxxxxx wrote:
> >> From: Mythri P K <mythripk@xxxxxx>
> >>
> >> Some of the header file definitions of HDMI IP are needed by audio driver thus
> >> moving the common defintion to more generic Include/video.
> >>
> >> Signed-off-by: Mythri P K <mythripk@xxxxxx>
> >> ---
> >>  drivers/video/omap2/dss/dss.h  |   10 -----
> >>  drivers/video/omap2/dss/hdmi.c |    1 +
> >>  drivers/video/omap2/dss/hdmi.h |   53 ------------------------
> >>  include/video/omaphdmi.h       |   86 ++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 87 insertions(+), 63 deletions(-)
> >>  create mode 100644 include/video/omaphdmi.h
> >
> > As the functions will be renamed to hdmi_ti_4xxx_*, perhaps the header
> > file is a bit misnamed.
> >
> > Also, please first do the changes/renamings/etc, and only then move the
> > finished header file to include/video/ to prevent unnecessary changes in
> > include/video.
> >
> The Include/video hdmi header file is a generic file that can be used
> across 4 ,5 and Netra. Actually even the hdmi_ti_5xxx_ definitions
> would come in this header so what do you think it can be named as ? ,
> If you have any better name for hdmi_ti_4xxx_ip as well please suggest
> would be happy to take it , as it doesn't sound that intuitive to me
> as well.

Well, I think whatever the header name is, it should somehow match the
functions and the .c file. So if the functions and the .c file in this
case are hdmi_ti_4xxx, then it'd be logical for the .h file to be named
similarly.

So, if it will contain functions for other IPs also, perhaps just leave
the 4xxx out of it and name it hdmi_ti.h. Then the functions could be
named hdmi_ti_4xxx_yyy(), and accordingly the .c file can be
hdmi_ti_4xxx.c.

Or, perhaps ti_hdmi.h (and funcs & .c files accordingly) would be more
"standard", as it's quite usual to name drivers etc. starting with the
company name.

 Tomi


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux